-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix zero address check in lookupAddress() #4086
Conversation
Oh yes! You are correct! This is due to previously using Thanks! :) |
Merged in v6.4.1. I'll be sure to get you added into the Thanks! |
Great, glad I could help and thanks for getting that change into a release! For future reference, was there a problem with the PR that prevented it from being merged? |
Oh, the PR was perfect. I just have crippling paranoia with just accepting a merge. I highly recommend checking out this repo to really amp up your fear of how even simple documentation changes and such can use BIDI and joiner UTF-8 characters and such to hide malicious code in seemingly safe code or pull requests. I am working on some CI workflows though, that will help make merging safe in the future. |
(and with libraries like Ethers and my AES libraries, I have a whole new level of security I prefer to enforce ;)) |
Thanks for pointing out that repo. The paper was a good read. Something else to look out for, I guess... |
Noticed earlier that we were sending
name(bytes32)
calls to the zero address. I think it's due to this invalid comparison preventing this from returning early and saving a bunch of unnecessary RPC calls.